This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Adding support for multiple devices, serial number constructor and example code #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added device serial number support, enabling multiple devices.
Updating Readme, improved multiple device handling, added example.js
|
Wonderful work @gordonturner, would you also like a commit bit so you can freely contribute to the project? |
andrew
added a commit
that referenced
this pull request
Jun 26, 2015
Adding support for multiple devices, serial number constructor and example code
|
Sure, that would be great, thanks @andrew. |
|
@gordonturner I've added you as a collaborator now, I'll push a new release to npm on Monday when I get home. |
|
Hey @andrew could I bother you to push a new release to npm? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on multiple device support and think I have a reasonable approach.
The pull request replaces the 'name' with 'serial number' as an optional constructor argument. With multiple devices, it is likely that they will share the same name, but the serial number is unique.
Updated the readme to include the changes and added an example.js.
Let me know if you think the pull request needs enhancements?
(Also, thanks for node-xbox-controller, nice to have something to start from!)